Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull upstream changes in netflix/bless into lyft's fork lyft/bless #39

Merged
merged 57 commits into from
Dec 10, 2019

Conversation

surbhishah
Copy link

@surbhishah surbhishah commented Dec 10, 2019

We did not have any lyft specific code on lyft/bless and git merge from netflix/bless was a fast forward.

diasjorge and others added 30 commits March 21, 2017 19:43
  * Use enum type and raise exception for wrong value
…validation in addition to bastion_user.

Added an email and principal validation option.
Updated bless_deploy_example with the new options.
bastion_user and remote_usernames now have configurable validation schemas.  See bless_request.py:USERNAME_VALIDATION_OPTIONS
added positive test mocking kmsauth sucessfully decrypting a token
…t, so that it better matches the format used when logging.
This change gives the option to validate the remote username against
the IAM groups containing the user invoking the lambda function. This
is an optional feature which is used in conjunction with kmsauth.

For example, if there were two groups of users, you could put your
admins in the ssh-admin IAM group to allow them to generate certificates
with a remote_username of 'admin'. Users with fewer permissions could be
in the ssh-user group to allow them to generate certificates for the 'user'
account.

The group name is configurable, however they must all be in a consistent
format, and must all contain the relevant remote_username once.
Netflix#74)

* Allowing BLESS lambda to accept ed25519 keys, completing Netflix#71 .  Thanks @jnewbigin .
* Moving BLESS to python 3.6.
You just need to rebuild, publish, and switch your lambda runtime from 2.7 to 3.6.

* Moving TravisCI to Python3.6 as well.
Allows username validation against IAM groups
russell-lewis and others added 22 commits July 26, 2018 11:48
Features include:
Python 3.6 Lambda support
Caching of the KMS decrypted CA Private Key Password.
Compressed CA Private Key support, allowing RSA 4096 keys to be set in the Lambda Environment.
Issue certificates for ED25519 public keys (RSA CA).
New option to validate the remote username against the IAM groups of the calling user.
Updated dependencies.
I had to go and discover the right link. I'd like to save that trouble for other readers.
Add link to Amazon Linux repository
The flag is not needed and breaks scripts if the input device does not have a TTY
* Plus minor formatting proposals
… request schemas.

You can now use bless_lambda_user.lambda_handler_user for user cert requests and bless_lambda_host.lambda_handler_host for host cert requests.  Please note that as implemented, anyone who can call the host lambda can obtain host certs for any hostname.
In addition to bless_lambda.lambda_handler, you can now use bless_lambda_user.lambda_handler_user for user cert requests and bless_lambda_host.lambda_handler_host for host cert requests.  Please note that as implemented, anyone who can call the host lambda can obtain host certs for any hostname.
Features include:
New support for a Host SSH Certificate Lambda.  Please consider how you will control who can obtain host certs for which hostnames before using.
Updated publishing code to build with the latest Amazon Linux 2.
Validated for Python 3.7 Lambda runtime.
Updated dependencies.
Various typo fixes.
@surbhishah surbhishah closed this Dec 10, 2019
@surbhishah surbhishah reopened this Dec 10, 2019
@surbhishah
Copy link
Author

👀 @skiptomyliu

@ryan-lane ryan-lane merged commit 8527924 into master Dec 10, 2019
@ryan-lane ryan-lane deleted the refresh-netflix-code branch December 10, 2019 21:17
@skiptomyliu skiptomyliu restored the refresh-netflix-code branch December 10, 2019 22:04
@skiptomyliu skiptomyliu deleted the refresh-netflix-code branch December 10, 2019 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.