forked from Netflix/bless
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull upstream changes in netflix/bless into lyft's fork lyft/bless #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use enum type and raise exception for wrong value
…validation in addition to bastion_user. Added an email and principal validation option. Updated bless_deploy_example with the new options.
Fixing typos in readme.
Enhancing PR#43.
bastion_user and remote_usernames now have configurable validation schemas. See bless_request.py:USERNAME_VALIDATION_OPTIONS
…to allow different remote_usernames
added positive test mocking kmsauth sucessfully decrypting a token
…t, so that it better matches the format used when logging.
This change gives the option to validate the remote username against the IAM groups containing the user invoking the lambda function. This is an optional feature which is used in conjunction with kmsauth. For example, if there were two groups of users, you could put your admins in the ssh-admin IAM group to allow them to generate certificates with a remote_username of 'admin'. Users with fewer permissions could be in the ssh-user group to allow them to generate certificates for the 'user' account. The group name is configurable, however they must all be in a consistent format, and must all contain the relevant remote_username once.
Netflix#74) * Allowing BLESS lambda to accept ed25519 keys, completing Netflix#71 . Thanks @jnewbigin .
* Moving BLESS to python 3.6. You just need to rebuild, publish, and switch your lambda runtime from 2.7 to 3.6. * Moving TravisCI to Python3.6 as well.
Allows username validation against IAM groups
Also cleaned up and added bz2 support to Netflix#67 .
Compressed CA private key support
Features include: Python 3.6 Lambda support Caching of the KMS decrypted CA Private Key Password. Compressed CA Private Key support, allowing RSA 4096 keys to be set in the Lambda Environment. Issue certificates for ED25519 public keys (RSA CA). New option to validate the remote username against the IAM groups of the calling user. Updated dependencies.
I had to go and discover the right link. I'd like to save that trouble for other readers.
Add link to Amazon Linux repository
The flag is not needed and breaks scripts if the input device does not have a TTY
… latest Amazon Linux.
* Plus minor formatting proposals
…' into lambda-host-split.
… request schemas. You can now use bless_lambda_user.lambda_handler_user for user cert requests and bless_lambda_host.lambda_handler_host for host cert requests. Please note that as implemented, anyone who can call the host lambda can obtain host certs for any hostname.
In addition to bless_lambda.lambda_handler, you can now use bless_lambda_user.lambda_handler_user for user cert requests and bless_lambda_host.lambda_handler_host for host cert requests. Please note that as implemented, anyone who can call the host lambda can obtain host certs for any hostname.
Features include: New support for a Host SSH Certificate Lambda. Please consider how you will control who can obtain host certs for which hostnames before using. Updated publishing code to build with the latest Amazon Linux 2. Validated for Python 3.7 Lambda runtime. Updated dependencies. Various typo fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did not have any lyft specific code on lyft/bless and git merge from netflix/bless was a fast forward.